Allow summary metrics to use custom time source #10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
I still need to add test cases, but wanted to run it through CI to take a look at the coverage. |
Pull Request Test Coverage Report for Build 2113568677
💛 - Coveralls |
ljbade
commented
Mar 30, 2022
| void ObserveMultiple(const std::vector<double>& bucket_increments, | ||
| const double sum_of_values); | ||
|
|
||
| /// \brief Get the current value of the counter. |
Author
There was a problem hiding this comment.
I just made upstream PR to fix this, so will remove from this commit.
ljbade
force-pushed
the
ljbade/summary-time-2
branch
from
fe1bcbc to
2a95ef7
Compare
|
@ljbade looks like this has some conflicts with master? |
Author
|
yeah I need to rebase |
ljbade
force-pushed
the
ljbade/summary-time-2
branch
from
2a95ef7 to
e6f1992
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
Summarymetric type uses an internalstd::chrono::steady_clockto track when to update the metric buckets.This PR changes it to use
system_clockand also adds functions to allow a custom time source to be passed into theObserve()andCollect()functions.This will allow summary metrics to be correctly calculated when replaying data.